-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(connector): [Worldpay] use 4 digit expiry year #6543
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
2 tasks
deepanshu-iiitu
previously approved these changes
Nov 12, 2024
@kashif-m Can you verify same in cypress test by passing 2 digit for worldpay |
Gnanasundari24
approved these changes
Nov 19, 2024
deepanshu-iiitu
approved these changes
Nov 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 19, 2024
pixincreate
reviewed
Nov 19, 2024
@@ -26,23 +26,23 @@ const browser_info = { | |||
"ip_address": "127.0.0.1" | |||
}; | |||
|
|||
const successfulNo3DSCardDetails = { | |||
const successfulNoThreeDsCardDetailsRequest = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick question: is the name verified with <test>.cy.js
?
bsayak03
pushed a commit
that referenced
this pull request
Nov 26, 2024
bsayak03
pushed a commit
that referenced
this pull request
Nov 26, 2024
AmeyWale-HS
pushed a commit
to AmeyWale-HS/hyperswitch
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Described in #6316 point # 7
Additional Changes
Motivation and Context
Helps in transforming expiry date format into a 4 digit value for card payments for worldpay connector!
How did you test it?
1. Create a payment using 2 digit expiry year
cURL
Response
Cypress
Checklist
cargo +nightly fmt --all
just clippy && just clippy_v2